[FEATURE]: [Helcim] Currency Unit Conversion

Sakilmostak commented 11 months ago

:memo: Feature Description

Each currency can be described in terms of base or minor units.
For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
In Hyperswitch, the amount value is expected to be always provided in minor units.
For example: In USD, If the amount is 1 in base unit (Dollar), then it will be equivalent to 100 in minor units (Cent)
Some of the connectors integrated require the amount to be converted to a desirable unit before being passed to them.
We have functions to_currency_base_unit and to_currency_lower_unit in place to convert the minor unit amount to its decimal equivalent and vice versa. These conversions are handled explicitly based on the connector.

:hammer: Possible Implementation

ConnectorCommon trait have been implemented for the connector.
This trait contains get_currency_unit method. This method needs to be implemented.
It will define what type of conversion needs to be done during connector_router_data creation. Concurrently handle the creation of connector_router_data to be passed for the connector request body creation.
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2196

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

ShatilKhan commented 11 months ago

Can you please assign me this issue? & some other guidelines as to the files that need to be changed

AkshayaFoiger commented 11 months ago

Hey @ShatilKhan , I see that you're already assigned to #2241 and are working on it. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2241 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

aachal28 commented 11 months ago

I would like to work on this. Can you assign it to me?

AkshayaFoiger commented 11 months ago

Hey @aachal28, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

VedantKhairnar commented 11 months ago

Hey @aachal28 , Let us know if you face any issues. Happy to help! : )

aachal28 commented 11 months ago

i'm reading documentation if i have any doubt i will ask to u

VedantKhairnar commented 11 months ago

Sure @aachal28, happy to help.

swangi-kumari commented 11 months ago

Hey @aachal28 , Are you still working on this issue? Please let us know if you need any help:)

deepanshu-iiitu commented 10 months ago

Hello @aachal28 , we didn't hear back from you, so we are unassigning you from this issue. If you are interested, we will assign you with other issues, if the current one is taken.

cb-dhivyadandapani commented 10 months ago

Hello team, could you please assign this issue to me?

deepanshu-iiitu commented 10 months ago

Hey @cb-dhivyadandapani , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

swangi-kumari commented 6 months ago

Hey @cb-dhivyadandapani , Are you still working on this issue? Please let us know if you need any help.

swangi-kumari commented 5 months ago

Hey @cb-dhivyadandapani , I am unassigning this issue from you as we didn't heard back from you and someone else can pick this up. If you still want to work with us, you can pick any open issue.

juspay / hyperswitch