[FEATURE]: [Rapyd] Use `connector_request_reference_id` as reference to the connector

Sakilmostak commented 11 months ago

:memo: Feature Description

We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
Presently, there is a lack of uniformity in this process, as some implementations employ payment_id while others utilize attempt_id.
This inconsistency arises from the fact that payment_id and attempt_id correspond to two distinct entities within our system.

:hammer: Possible Implementation

To mitigate this confusion, we've introduced a new field called connector_request_reference_id in our RouterData.
This id should replace them as a reference id to the connector for payment request.
One might need to have exposure to api docs of the connector for which it is being implemented.
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2052

:bookmark: Note : All the changes needed should be contained within hyperswitch/crates/router/src/connector/

:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

soumya-dash3 commented 11 months ago

Hello @Sakilmostak , can I be assigned this issue please?

AkshayaFoiger commented 11 months ago

Hey @soumya-dash3, , I see that you're already assigned to #2295 and are working on it. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2295 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

ankushbhardwaj408 commented 11 months ago

Hi @AkshayaFoiger i am new to open source ,eager to contribute.Seeking guidance to start my journey.Any help appreciated. Thank You!!

AkshayaFoiger commented 11 months ago

Hey @ankushbhardwaj408, Thank you for getting in touch. Certainly, issue #2315 presents itself as an excellent opportunity for initiating open-source contributions. First I would recommend you to start with setting up hyperswitch in your local system

 To gain understanding of this Issue, I would like to elucidate how it has been resolved in the context of Adyen. On examining the Adyen documentation regarding payment requests, it is evident that they accept a field known as reference within their API requests for creating a transaction. This reference serves is an id that we can pass in the request, as a means to specifically identify and reference individual payments, and thus, it can been aptly designated as a connector_request_reference_id. We have accordingly made the necessary modifications to the connector/adyen/transformer.rs file, to include reference field in both payment requests and responses. I recommend reviewing the details of these changes in this associated Pull Request.

For specific guidance on the Rapyd connector, please refer here.

Hint: This is the definition of required field Identifier defined by the client for reference purposes. Limit: 45 characters.

I hope this information proves helpful. In case you have any further queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

AkshayaFoiger commented 11 months ago

@ankushbhardwaj408 , Shall I assign this issue to you?

ankushbhardwaj408 commented 11 months ago

Hello @AkshayaFoiger thanks for your help. I would like to contribute. Please assign it to me. If I encounter any problems I will contact you.

AkshayaFoiger commented 11 months ago

Hey @ankushbhardwaj408 , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

ankushbhardwaj408 commented 11 months ago

Hi @AkshayaFoiger No variables like payment_id and attempt_id are used in Rapyd.

Sakilmostak commented 11 months ago

Hello @ankushbhardwaj408 , on reading through Rapyd Api Docs, they are passing a field called merchant_reference_id which can be used as reference to transaction

deepanshu-iiitu commented 10 months ago

Hey @ankushbhardwaj408 Just checking in - are you working on it? Do you need help from our side?

ankushbhardwaj408 commented 10 months ago

Hi @deepanshu-iiitu I am not familiar with the tech stack used in the project and so any help would be appreciated. I have installed Docker and run all the commands until the server is up and it shows good health on localhost but I don't know what to do next

deepanshu-iiitu commented 10 months ago

Hey @ankushbhardwaj408 You can reference the following PR https://github.com/juspay/hyperswitch/pull/2631 It contains a similar implementation that is required for this issue.

TejasMate commented 10 months ago

hey @deepanshu-iiitu, Could you please assign this issue to me? since @ankushbhardwaj408 is inactive

deepanshu-iiitu commented 10 months ago

Hey @TejasMate , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

swangi-kumari commented 5 months ago

Hey @TejasMate , Are you still working on this issue? Let us know if you need any help.

dalprahcd commented 4 months ago

Hello @swangi-kumari, can you assign this issue to me? I would like to help.

Sakilmostak commented 3 months ago

Hi @dalprahcd , sure, I will assign this issue to you.

dalprahcd commented 3 months ago

Hello @Sakilmostak sorry but I will not be able to help with this issue in the time being.

juspay / hyperswitch