search

juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable
https://hyperswitch.io/
Apache License 2.0
11.66k stars 1.23k forks source link

[REFACTOR] Update HTTP Method for Retrieving GSM Records (/gsm/get) API to GET and Retrieve Fields via Query Parameters Instead of Request Body #2820

Open sai-harsha-vardhan opened 10 months ago

sai-harsha-vardhan commented 10 months ago

Feature Description

Currently, the GSM Retrieve API (/gsm/get) accepts requests using the POST method, with fields being submitted in the request body. Ideally, it should be a GET method API, with fields accepted as query parameters

Possible Implementation

Change the HTTP method of the GSM Retrieve API (/gsm/get) to GET and modify it to accept fields in the query parameters

goku321 commented 10 months ago

I would like to work on this :)

sai-harsha-vardhan commented 10 months ago

Sure, @goku321, I've assigned it to you. Thanks for your interest. Feel free to use the issue thread or our Discord channel if you have any queries.

goku321 commented 10 months ago

Sure, @sai-harsha-vardhan. Thanks :)

sai-harsha-vardhan commented 9 months ago

Hey @goku321, If you are stuck / need some help, please feel free to ask queries here / our discord channel. Thanks!

goku321 commented 9 months ago

Hi @sai-harsha-vardhan Thanks for the follow up. I started making the changes but then got caught up with some other things. I will try to finish this within this week. Will reach out if I have any questions. Thanks :)

sai-harsha-vardhan commented 9 months ago

@goku321, Thanks for the update!

GunniBusch commented 5 months ago

Hi, I would like to ask if @goku321 is still working on this and if not, @sai-harsha-vardhan is this still something someone is working on? Because we need this so the openapi spec is correct, and does not generate a warning about a body in a get; delete request.

Thanks

goku321 commented 4 months ago

Hi @GunniBusch I made multiple attempts but couldn't conclude it due to a busy schedule. Please feel free to take this up. I would really appreciate that. Thanks for your patience