[REFACTOR] : [Helcim] Error Message For Connector Implementation - Githubissues

juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable

https://hyperswitch.io/

Apache License 2.0

11.66k stars 1.23k forks source link

[REFACTOR] : [Helcim] Error Message For Connector Implementation #2841

Closed swangi-kumari closed 9 months ago

swangi-kumari commented 10 months ago

:memo: Feature Description

In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation.

:hammer: Possible Implementation

In order to manage payment methods that are not implemented by Hyperswitch or yet to be implemented, the connector transformers file should make use of the NotImplemented ConnectorError enum variant.
By doing so, we will throw same error message for all the Connector Implementation
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2831

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

oscar2d2 commented 10 months ago

I would like to take this. Please review my PR.

swangi-kumari commented 10 months ago

Sure @oscar2d2