[FEATURE] : add pagination support for customers list

juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable

https://hyperswitch.io/

Apache License 2.0

12.56k stars 1.35k forks source link

[FEATURE] : add pagination support for customers list #3746

Open Narayanbhat166 opened 8 months ago

Narayanbhat166 commented 8 months ago

Feature Description

The customers list endpoint currently has no pagination support. It returns the list of all the customers in the database. There would be thousands of customers for a merchant. A pagination support for the api would be necessary.

Possible Implementation

accept two fields, limit and offset

limit specifies the number of objects returned in the response.
offset specifies the number of items to skip from the start, this is open to discussion whether to use offset or some other field.

This would be similar to the payments_list pagination. Refer here

Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to submit a PR?

None

tanbirali commented 8 months ago

I am interested to take this issue, I will like to know little bit more, from what I saw both product list and customer list look same to me.

Narayanbhat166 commented 8 months ago

Hey @tanbirali, thanks for showing interest. Payment list accepts limit and other parameters, which are used for pagination. These parameters are not available in customers list endpoint.

tanbirali commented 8 months ago

Okay, correct me if I am wrong, I have to create a CustomerListConstraints where I need to add limit and offset

Narayanbhat166 commented 7 months ago

Yes, you would have to create the struct and add limit and offset to it.

hegdeadithyak commented 7 months ago

Hi there @Narayanbhat166 ,

I'd like to take a look at this issue and see if I can help fix it. Please let me know if it's already assigned to someone or if there's anything specific I should keep in mind while working on it.

Thanks, Adithya Hegde Kota

Narayanbhat166 commented 2 months ago

Hey @hegdeadithyak, let me know if you are interested in contributing. I can get you another issue to work on

hegdeadithyak commented 2 months ago

Hey @hegdeadithyak, let me know if you are interested in contributing. I can get you another issue to work on

Yes, I am Intrested.

Thanks, Adithya Hegde Kota