[REFACTOR]: [Mollie] Remove Default Case Handling

swangi-kumari commented 6 months ago

We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
These conditions generally go hand in hand with enum variants.
Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
So, if all the explicit cases are handled then default is used to handle the rest.
Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

Instead of relying on a default match case _, developers should handle each and every variant explicitly.
By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
In order to manage payment methods that are not implemented by Hyperswitch or yet to be implemented, the connector transformers file should make use of the NotImplemented ConnectorError enum variant.
By doing so, we will throw same error message for all the Connector Implementation
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/mollie/transformer.rs

davidkurilla commented 4 months ago

I'd like to work on this issue! Thanks.

Sakilmostak commented 4 months ago

Sure @davidkurilla , I am assigning this issue to you. Hope you have a happy time contributing :)

juspay / hyperswitch