[REFACTOR]: [STAX] Add amount conversion framework to Stax

ImSagnik007 commented 2 months ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
Connectors should invoke the convert function to receive the amount in their required format.
Refer to the connector documentation to determine the required amount format for each connector.
You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

[ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[ ] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Monis-Ahmed-Rizvi commented 1 month ago

I’d be happy to take on this issue if no one else is actively working on it.

gorakhnathy7 commented 1 month ago

Hey Guys, Kindly request assignment for one issue at a time, and don't spam. You can ask for the next issue to be assigned, once you have completed the earlier assigned one.

Monis-Ahmed-Rizvi commented 1 month ago

when i wrote that request no issue was assigned to me

amitroy-thedev commented 1 month ago

Hey @gorakhnathy7 I would like to work on the issue, If nobody is assigned to this issue, assign it to me..

gorakhnathy7 commented 1 month ago

Hey @amitroy-thedev Assigned the issue to you, Thanks for your interest.

amitroy-thedev commented 1 month ago

Hey @gorakhnathy7 would you please guide me where should I make changes I am unable to find files in hyperswitch/crates/router/src/connector/ it is in the hyperswitch/crates/hyperswitch_connector/src/connector/

swangi-kumari commented 1 month ago

Hey @gorakhnathy7 would you please guide me where should I make changes I am unable to find files in hyperswitch/crates/router/src/connector/ it is in the hyperswitch/crates/hyperswitch_connector/src/connector/

Hey @amitroy-thedev , You have to make changes in hyperswitch/crates/hyperswitch_connector/src/connector/.

amitroy-thedev commented 1 month ago

Hey @swangi-kumari @gorakhnathy7 @ImSagnik007 @deepanshu-iiitu @SanchithHegde i have refactored amount conversion would you please review it..

gorakhnathy7 commented 1 month ago

Hey @amitroy-thedev Thanks for being so prompt here, we will soon do the review and share feedback, if any.

amitroy-thedev commented 1 month ago

@gorakhnathy7 Okay 🙂

juspay / hyperswitch