[REFACTOR]: [NUVEI] Add amount conversion framework to Nuvei

mrudulvajpayee4935 commented 4 weeks ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
Connectors should invoke the convert function to receive the amount in their required format.
Refer to the connector documentation to determine the required amount format for each connector.
You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:package: Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

kaustubh1106 commented 3 weeks ago

@mrudulvajpayee4935 sir I want to work on this issue

kaustubh1106 commented 3 weeks ago

@mrudulvajpayee4935 can you please reveiw my PR and please can you help me with its testing how can I test it can you provide me the steps

gorakhnathy7 commented 3 weeks ago

Hey @kaustubh1106 Thanks for working on this! This will be reviewed soon!

Ankesh2004 commented 3 weeks ago

Hi @gorakhnathy7 , I would like to work on this issue. Please assign it to me.

sOnU1002 commented 3 weeks ago

hey i can work on it please assign it to me

gorakhnathy7 commented 3 weeks ago

Hey @Ankesh2004 @sOnU1002 Thanks for showing interest, But there is another PR in review, which can close this issue. To save everyone's time I would suggested picking another issue.

kaustubh1106 commented 2 weeks ago

hi @mrudulvajpayee4935 are there any changes I need to do ?

mrudulvajpayee4935 commented 2 weeks ago

hey @kaustubh1106 i will review this and let you know.

juspay / hyperswitch