juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable
https://hyperswitch.io/
Apache License 2.0
12.67k stars 1.35k forks source link

[REFACTOR]: [NEXINETS] Add amount conversion framework to Nexinets #6095

Open swangi-kumari opened 2 months ago

swangi-kumari commented 2 months ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

:package: Have you read the Contributing Guidelines?

:package: Submission Process:

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

hex1c commented 2 months ago

@swangi-kumari Can you assign it to me, i would like to work on this

gorakhnathy7 commented 2 months ago

Hey @hex1c Assigning this issue to you!

gorakhnathy7 commented 2 months ago

Hey @swangi-kumari kindly review this!