[REFACTOR]: [TSYS] Add amount conversion framework to Tsys

swangi-kumari commented 4 weeks ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
Connectors should invoke the convert function to receive the amount in their required format.
Refer to the connector documentation to determine the required amount format for each connector.
You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

[ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[ ] I have read the Contributing Guidelines

:package: Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

gauravghodinde commented 3 weeks ago

hey i would like to contribute to this issue can you please assign it to me?

gorakhnathy7 commented 3 weeks ago

Hey @gauravghodinde Assigning this issue to you!

gorakhnathy7 commented 2 weeks ago

Hey @gauravghodinde ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

gauravghodinde commented 2 weeks ago

hey @gorakhnathy7 , i have made the required changes, how can i check if they are working fine?

juspay / hyperswitch