[REFACTOR]: [WORLDLINE] Add amount conversion framework to Worldline

swangi-kumari commented 3 weeks ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
Connectors should invoke the convert function to receive the amount in their required format.
Refer to the connector documentation to determine the required amount format for each connector.
You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

[ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[ ] I have read the Contributing Guidelines

:package: Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

Ankesh2004 commented 3 weeks ago

Hi @swangi-kumari , I would like to work on this issue. Please assign it to me.

SanchitMahajan236 commented 3 weeks ago

I would like to work on this issue. Can you please assign me this issue ?

gorakhnathy7 commented 3 weeks ago

Hey guys, both of you are working on other issues, Let me once those issues are completed i can assign more issues to you!

Ankesh2004 commented 3 weeks ago

@gorakhnathy7 I have submitted PR for my other issues, and got approved by one maintainer , needs one more to approve to get merged. Meanwhile, i can take this one.

gorakhnathy7 commented 3 weeks ago

Sure @Ankesh2004 Assigning this to you!

gorakhnathy7 commented 2 weeks ago

Hey @Ankesh2004 ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

hex1c commented 6 days ago

@gorakhnathy7 if the issue is up for grabs, i would like to work on this. Please assign this to me.

gorakhnathy7 commented 6 days ago

Hey @Ankesh2004 i don't see any activity here, let me know if you want to work on any other issue? I can assign this issue to other contributors in that case.

Ankesh2004 commented 6 days ago

Hey @Ankesh2004 i don't see any activity here, let me know if you want to work on any other issue? I can assign this issue to other contributors in that case.

I have worked on it, will raise a PR today in a few hours

Ankesh2004 commented 6 days ago

@swangi-kumari @gorakhnathy7 I have raised the PR , Please review it.

juspay / hyperswitch