juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable
https://hyperswitch.io/
Apache License 2.0
12.31k stars 1.32k forks source link

[REFACTOR]: [RISKIFIED] Add amount conversion framework to Riskified #6139

Open ImSagnik007 opened 3 weeks ago

ImSagnik007 commented 3 weeks ago

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Submission Process:

Refer here for Terms and conditions for the contest.

tanbirali commented 3 weeks ago

I am interested

Ankesh2004 commented 3 weeks ago

Hi @ImSagnik007 , I would like to work on this issue. Please assign it to me.

IshuSinghSE commented 2 weeks ago

Hello! Could you assign this to me? @ImSagnik007

gorakhnathy7 commented 2 weeks ago

Hey All, assigning this issue to @IshuSinghSE to maintain fairness, As rest of the folks are already working on other issues.

Sidharth-Singh10 commented 2 weeks ago

Hey @gorakhnathy7 , as there is no current assignee , Could you assign this to me?

gorakhnathy7 commented 2 weeks ago

Hey @Sidharth-Singh10 Can you please pick any other issue from here.

Sidharth-Singh10 commented 1 week ago

@gorakhnathy7, can I pick up this issue? as there is no current assignee.

gorakhnathy7 commented 1 week ago

Sure @Sidharth-Singh10 Assigning this to you, Thanks for your interest.