fix(router): change Not Found response to Internal Server Error for empty vector - Githubissues

juspay / hyperswitch

An open source payments switch written in Rust to make payments fast, reliable and affordable

https://hyperswitch.io/

Apache License 2.0

12.1k stars 1.27k forks source link

fix(router): change Not Found response to Internal Server Error for empty vector #6150

Open shreyshukla29 opened 5 days ago

shreyshukla29 commented 5 days ago

…ctor (#5916)

Modified the get_aggregates_for_payments function to address issue #5916.

Replaced the to_not_found_response handler with map_err to handle internal errors during data fetching.
Ensured that an empty vector returned from the get_intent_status_with_count method is treated as valid and does not result in a "Not Found" error.
Now, an Internal Server Error (HTTP 500) is returned only when there is an actual problem with fetching data from the database.
Attached a descriptive error message using attach_printable to provide more context in case of internal errors.

This fix ensures that valid empty results no longer cause false error responses and internal issues are correctly flagged with a 500 error.

Type of Change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

semanticdiff-com[bot] commented 5 days ago

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 59% smaller than the GitHub diff.

	Filename	Status
:heavy_check_mark:	crates/router/src/core/payments.rs	58.67% smaller