juspay / services-flake

NixOS-like services for Nix flakes
https://community.flake.parts/services-flake
MIT License
369 stars 31 forks source link

Improve speed of tests #133

Closed srid closed 7 months ago

srid commented 7 months ago

Running nixci on my mac is extremely slow mainly due to grafana build. The slowness also translates to all of CI platforms.

Tests should run swiftly as possible. Our project is not complicated. If something's fucked in nixpkgs, we shouldn't have to get hit by slow build times.

shivaraj-bh commented 7 months ago

We can improve the build time by disabling check for grafana instead.

srid commented 7 months ago

disabling check for grafana instead

I tried that, it was still taking a while to build locally.

These broken packages should be a temp issue, so I'd say let's just use older nixpkgs until they fix it upstream. We benefit from official cache.

srid commented 7 months ago

Also less code is generally better. We don't want to maintain our own $package derivations. That's nixpkgs' job.

shivaraj-bh commented 7 months ago

Okay, I will fix it upstream then.