search

juspay / services-flake

NixOS-like services for Nix flakes
https://community.flake.parts/services-flake
MIT License
369 stars 31 forks source link

Fix pgadmin scripts on MacOS #163

Closed Javyre closed 6 months ago

Javyre commented 6 months ago

Hey, just a little fix for mac: readlink -m is invalid on mac. Added coreutils as a runtime input for darwin.

Other scripts in the repo have a similar issue (using the -m flag for e.g.) but I am not using them atm so cannot QA very well.

shivaraj-bh commented 6 months ago

Thanks for the contribution! One small addition, could you reword the commit to something like: fix(pgadmin): <commit-description>. This has to be documented, but we are planning to auto-generate changelog from commits and this will be helpful.

shivaraj-bh commented 6 months ago

Thanks for pointing it out in other services.

I have fixed it one other service: https://github.com/juspay/services-flake/pull/164

We use readlink -m even in cassandra but the startScript there already has coreutils as a runtimeInput.