fix(grafana): add `coreutils` as runtimeInput for the startScript

shivaraj-bh commented 6 months ago

readlink shipped by default in macOS doesn't support -m flag

srid commented 6 months ago

We have macOS CI; shouldn't grafana_test.nix have caught this?

shivaraj-bh commented 6 months ago

Yes, I tried to debug this.

When the nix flake check happens on macOS, grafana doesn’t have any problem finding the data dir with readlink -m (hinting that it is somehow using the readlink from coreutils):

grafana-test> [gf1      ] logger=sqlstore t=2024-04-14T02:55:20.597021Z level=info msg="Creating SQLite database file" path=/private/tmp/nix-build-grafana-test.drv-0/data/gf1/grafana.db

But when I run the process-compose app with nix run, it chooses to use the readlink from macOS’ /usr/bin:

[gf1    ] readlink: illegal option -- m
[gf1    ] usage: readlink [-fn] [file ...]

As a result, it tries to default to the /nix/store path as its data directory:

[gf1    ] logger=sqlstore t=2024-04-14T08:36:59.551036+05:30 level=info msg="Creating SQLite database file" path=/nix/store/yjfc9zvy1i1dsm9jr4ixdh5fdf062agy-grafana-10.4.1/share/grafana/grafana.db

shivaraj-bh commented 6 months ago

Looks like it is to do with runCommand:

nix-repl> :b legacyPackages.aarch64-darwin.runCommand "readlink-test" { } "${legacyPackages.aarch64-darwin.which}/bin/which readlink > $out”

This derivation produced the following outputs:
  out -> /nix/store/p50kx540nd6d73wqd8jik6n064ww34lx-readlink-test

❯ cat /nix/store/p50kx540nd6d73wqd8jik6n064ww34lx-readlink-test
/nix/store/vinxz6lkrilb72dkzr3ny02nnvql6z50-coreutils-9.4/bin/readlink

shivaraj-bh commented 6 months ago

runCommand’s drv has stdenv-darwin as an input, which is where coreutils is coming from:

"inputDrvs": {
      "/nix/store/32l6ffg3wc6vxnd6fdrjar7ys20k6faw-stdenv-darwin.drv": {
        "dynamicOutputs": {},
        "outputs": [
          "out"
        ]
      },
    }

❯ nix derivation show /nix/store/32l6ffg3wc6vxnd6fdrjar7ys20k6faw-stdenv-darwin.drv | grep "coreutils-9.4.drv" -C2
        ]
      },
      "/nix/store/w16pjjgny0akzn3v53nsx28vcp03h16x-coreutils-9.4.drv": {
        "dynamicOutputs": {},
        "outputs": [

juspay / services-flake

fix(grafana): add `coreutils` as runtimeInput for the startScript #164