Closed srid closed 1 month ago
Shouldn't https://github.com/juspay/services-flake/issues/53 prevent this?
Only if contributors always use that template and promise to never hand edit the generated dataDir
option.
Should we add namespace
to this consideration as well?
c. https://github.com/juspay/services-flake/pull/219#issuecomment-2166758801
namespace
and dataDir
are going to follow the same convention across services, so how about creating a default module and importing it in https://github.com/juspay/services-flake/blob/main/nix/lib.nix?
Edit: To be specific, here: https://github.com/juspay/services-flake/blob/14a37407105c948fb79f2933c22a5ada4ab22f60/nix/lib.nix#L25
Good idea.
Make sure to use lib.mkDefault
though.
This should be fairly simple to implement after #258 (which does it for namespace
)
Easy to break this convention in new PRs
e.g.: https://github.com/juspay/services-flake/pull/195#discussion_r1615217405