search

jussi-kalliokoski / audiolib.js

audiolib.js is a powerful audio tools library for javascript.
http://audiolibjs.org/
672 stars 58 forks source link

The usage of new is too complicated #33

Closed jussi-kalliokoski closed 13 years ago

jussi-kalliokoski commented 13 years ago

This should be made simpler.

Currently with audioLib.Sink the new is optional, but for most of the effects it's not, and with effect.createBufferBased() you must not use it. So maybe a good idea would be to make it optional everywhere, so that the recommendation would be not to use it at all.

This should however be done in the library architecture side, not affecting the actual effects code with some weird cruft.

jussi-kalliokoski commented 13 years ago

I need a second opinion on this, but I feel like the current way is nice. After closing, I think we're good to go for v.0.5.0. :)

jussi-kalliokoski commented 13 years ago

Second opinion confirmed, closing!