search

jussi-kalliokoski / audiolib.js

audiolib.js is a powerful audio tools library for javascript.
http://audiolibjs.org/
672 stars 58 forks source link

fixed naming bug in iirfilter, added test for Distortion #44

Closed kindohm closed 12 years ago

kindohm commented 12 years ago

While trying out the Distortion effect I discovered a bug in IIRFilter with the naming of the sampleRate param. I fixed the bug, and also created a test for Distortion.

A new version of the integrated sink.js is also included in this commit.

jussi-kalliokoski commented 12 years ago

Thanks for the pull request and spotting the bug, but the changes in the sink.js look suspicious, the current version should be the one that's most up to date. Even if that is the same version, it still is a lot of dirt to the diff, so I have to ask you if you could do a bit of git magic and recreate the commit without the sink.js changes. If that's too much to ask, I can also do it myself, but it would be great if the commit had your name on it. :)

kindohm commented 12 years ago

I agree that diff looked very suspicious. I figured that maybe the latest version of Sink just hadn't been applied yet. I'll take another look later so that this commit can be cleaner.

jussi-kalliokoski commented 12 years ago

Thanks, much appreciated! :)