jussi-kalliokoski / audiolib.js

audiolib.js is a powerful audio tools library for javascript.
http://audiolibjs.org/
672 stars 58 forks source link

Implement Reverb / Convolution #8

Closed jussi-kalliokoski closed 13 years ago

jussi-kalliokoski commented 13 years ago

Want! As many algorithms as possible.

davidgovea commented 13 years ago

doink #27

jussi-kalliokoski commented 13 years ago

Yay!! Will keep the issue open until 0.5.0

davidgovea commented 13 years ago

What sort of release timeframe do you have in mind?

jussi-kalliokoski commented 13 years ago

Not sure yet, I'm hoping to release on 12.08., but if that becomes impossible, I'll have to delay it. I'm trying to pack as many of the upcoming non-backwards-compatibilities to the v.0.5.0, and I'm hoping the main parts of the API are stable by then. Which brings us back to questions in #3 .

jussi-kalliokoski commented 13 years ago

I think the Freeverb algorithm is quite good for a core component, the rest should probably be made plugins.

davidgovea commented 13 years ago

I've reviewed the multichannel effect changes.. looking good! I'll be refactoring freeverb to use the new setParam format for changing room size and such.

jussi-kalliokoski commented 13 years ago

Cool! So, yes, the setParam is part sugar, part hopeful optimization, due to the fact that you can just override it in the prototype when the effect has dynamic features.

davidgovea commented 13 years ago

Updated freeverb, but it's sounding kinda metallic and quiet compared to the first version. I'll be bug hunting soon e1ea5548fafb59bf46d3 7c7a405d9085d1a33922 8a47e36fe42a39473cde

jussi-kalliokoski commented 13 years ago

Looks good to me, closing.