Closed spencerbeggs closed 6 years ago
I also updated Travis to use Node 8 build environment. The tests were failing on Node 0.10. Gulp 4 has issue with v0.10, but that's pretty far out of date at this point, imo.
Cool! Congratz on your first contribution and sorry that it took so long to come under my radar! This looks all good to me, aside from using different code formatting. I'd be highly in favor of adopting prettier, but it should be in a separate PR, as the scope is different.
Awesome. I pushed a commit that returns the code to the previous formatting.
Published in https://github.com/jussi-kalliokoski/gulp-awspublish-router/commit/5b12050d564dd9960e41ef03e60732e90ab346f5 as v0.2.0 :tada:
Good work, thank you!!! 🙏
Hi, Jussi,
This is just a quick PR that upgrades the dependencies in this module to squelch warnings during installation and also to avoid dependencies with know security issues. These are the issues resolved:
I also updated Gulp to v4 and as part of that upgraded the gulp-awspublish dependency to the latest version to avoids the deprecation of gulp-util: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5