jussi-kalliokoski / webmidi-issues

A test repo for importing the issues from bugzilla
0 stars 0 forks source link

Allowed contents of send( data ) needs to be detailed. #36

Closed jussi-kalliokoski closed 11 years ago

jussi-kalliokoski commented 11 years ago

Originally reported on W3C Bugzilla ISSUE-19976 Fri, 16 Nov 2012 00:13:27 GMT Reported by Chris Wilson Assigned to Chris Wilson

I realized I had not explicitly detailed what can go in the data bytes in a send() call. I believe this should be effectively what can go in a MIDIPacket in CoreMIDI:

A variable-length stream of MIDI messages. Running status is not allowed. In the case of system-exclusive messages, a packet may only contain a single message, or portion of one, with no other MIDI events. The MIDI messages in the packet must always be complete, except for system-exclusive.

jussi-kalliokoski commented 11 years ago

Original comment by Jussi Kalliokoski on W3C Bugzilla. Fri, 16 Nov 2012 12:20:51 GMT

(In reply to comment #0)

I realized I had not explicitly detailed what can go in the data bytes in a send() call. I believe this should be effectively what can go in a MIDIPacket in CoreMIDI:

A variable-length stream of MIDI messages. Running status is not allowed. In the case of system-exclusive messages, a packet may only contain a single message, or portion of one, with no other MIDI events. The MIDI messages in the packet must always be complete, except for system-exclusive.

Sounds good to me.

jussi-kalliokoski commented 11 years ago

Original comment by Chris Wilson on W3C Bugzilla. Mon, 19 Nov 2012 18:00:16 GMT

Fixed by https://dvcs.w3.org/hg/audio/rev/e0f3c5871603.

I actually made it "complete messages only" - i.e. sysex messages must be complete as well. Without this stricture, we would have to be more explicit about the state of the MIDI message handler (i.e., if a partial message was the last thing received, we would need to know that the next message has no valid MIDI header byte). From previous discussion, I don't believe we decided we really needed partial sysex; if so, please open another bug to track.

jussi-kalliokoski commented 11 years ago

Original comment by Olivier Thereaux on W3C Bugzilla. Tue, 11 Dec 2012 09:42:17 GMT

Seeing no objection. Closing.