just-bi / odxl

Open Data Export Layer
Apache License 2.0
13 stars 7 forks source link

Should check if sheetnames are valid #31

Closed rpbouman closed 7 years ago

rpbouman commented 7 years ago

Sheetnames have to comply to at least 2 constraints:

(can be reduced to 1 regex check: ^[^'\[\]/\:?]{1}[^\[\]/\:?]{0,30}$)

Both the service and the sample app should check this. On the server side,the error should be 400 BAD REQUEST.

rpbouman commented 7 years ago

Fixed by https://github.com/just-bi/odxl/commit/7269836fa817a8c5324dc65c060c6bbe7f50dc86 (service) and https://github.com/just-bi/odxl/commit/0c67cc4a0b90044368d2c9bddf2670342042a951 (app)