Closed Meesayen closed 9 years ago
Briliant! It's a better solution than I have.
But why you removed some arguments from methods? They already still there when less calling us, and if you omit it, it easy to forget about it.
@just-boris I just removed them for JSHint pleasure, it always complain about variables that are defined but never used. I suggest to keep them out and document the input parameters in a comment.
Ok. I will do it and add JSHint validation into build.
Merged. Thanks!
The initial implementation of this plugin can leave the user wondering where exactly the issue is located, when he is presented with an error output like this:
This PR fix this by keeping the reference of each processed file, by simply replacing the
glob
import with a list of imports, one for each file that matched theglob
pattern. The error output would be something like this:(the error output in the example above is produced by the gulp-less plugin for gulp, going through the gulp-plumber)