search

just3obad / smartsoft-12

Automatically exported from code.google.com/p/smartsoft-12
0 stars 0 forks source link

3.2 As an admin, I can login/logout to the admin main page. #110

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Success scenarios:
 in case of logging in he : enter the main page,in case of logging out he returns to login page
Failure scenarios:
in case of login : stay in the loggin page with a message telling him what is 
wrong.

Original issue reported on code.google.com by mouaz.alabsawi@gmail.com on 11 May 2012 at 5:36

GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 11 May 2012 at 5:36

GoogleCodeExporter commented 9 years ago 
Why is this story New still?

Haven't the tests for them started yet!?

Original comment by guc@sakr.me on 13 May 2012 at 1:37

GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 13 May 2012 at 4:09

GoogleCodeExporter commented 9 years ago 
A kind reminder that our deadline is in less than 2 hours.

Original comment by guc@sakr.me on 13 May 2012 at 8:19

GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 13 May 2012 at 11:37

GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 15 May 2012 at 7:46

GoogleCodeExporter commented 9 years ago 
there are 2 png files with name 3.2 ... please fix them
the one related to this story doesn't have method names on the arrows and no 
return names also.

Original comment by EssamAhm...@gmail.com on 19 May 2012 at 1:14

GoogleCodeExporter commented 9 years ago 
it is (3.2(2))

Original comment by mouaz.alabsawi@gmail.com on 19 May 2012 at 1:16

GoogleCodeExporter commented 9 years ago 
Documentation should be in the format:
= begin
Method description
Parameters (inputs, outputs)
Author: Mouaz
= end
In addition to simple in line documentation to inside the methods

Original comment by bassemaw...@gmail.com on 19 May 2012 at 2:04

GoogleCodeExporter commented 9 years ago 
 -logout is working , but I guess if the login Textfields where padded a little bit to the right it would look better or even in the Middle of the page 

-the error red message (design Issue )

-when the admin isn't logged in , he can enter some pages that he shouldn't be 
allowed to ( I think this is the responsibility of other developers but i guess 
it's time to make an Issue about this )

Original comment by jailan.s...@gmail.com on 19 May 2012 at 2:31

GoogleCodeExporter commented 9 years ago

Original comment by jailan.s...@gmail.com on 19 May 2012 at 2:32

GoogleCodeExporter commented 9 years ago 
1- You should remove RED from the name of your tests.
2- You should test for the routes in the functional and passing the parameters 
correctly.
3- You should test the case of successful login/logout and that he is 
redirected to the correct page.
4- You should fix the errors in "should not save admin with first and last name 
should be greater than  3 letters 1 RED" and "should not save admin with 
invalid email 2 RED".

Original comment by gosgosakila on 19 May 2012 at 3:12

GoogleCodeExporter commented 9 years ago 
What are your recommendations on how to enforce login to all admin pages? Are 
there instructions for devs who are working on admin pages to make sure their 
actions are secure against non-admins?

I can still access /logs without logging in.

Original comment by guc@sakr.me on 20 May 2012 at 1:01

GoogleCodeExporter commented 9 years ago 
do not use this :
 @admin_session = AdminSession.find
  if @admin_session == nil
use
  if current_admin == nil

it exist in your model and in your controller

when loged in please show in the view the email of Admin not his first_name
and like Sakr is saying to you you need to make an issue to tell others that 
they need to add 
  if current_admin == nil
in each beginning of there controller so if there is no Admin the attempt to 
access is redirected to your login page again.

Original comment by mina.wor...@gmail.com on 20 May 2012 at 1:08

GoogleCodeExporter commented 9 years ago 
please handle the case of not rendering the template of application.html.erb

Original comment by mina.wor...@gmail.com on 20 May 2012 at 1:19

GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 20 May 2012 at 7:53

GoogleCodeExporter commented 9 years ago 
just 2 things now
1- nothing returned to actor admin,,, it's returned to the view

2- what is the index arrow back ??  stories controller

Original comment by EssamAhm...@gmail.com on 23 May 2012 at 10:17

GoogleCodeExporter commented 9 years ago

Original comment by bassemaw...@gmail.com on 23 May 2012 at 6:34

GoogleCodeExporter commented 9 years ago 
Where are the tests for this issue ??

Original comment by gosgosakila on 23 May 2012 at 7:19

GoogleCodeExporter commented 9 years ago 
please remove the flash of success in login

Original comment by mina.wor...@gmail.com on 23 May 2012 at 7:42

GoogleCodeExporter commented 9 years ago 
when entering invalid info the message appears plain without any red flashes , 
is this done on purpose ?

Original comment by jailan.s...@gmail.com on 23 May 2012 at 9:28

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by mina.wor...@gmail.com on 25 May 2012 at 5:57

GoogleCodeExporter commented 9 years ago

Original comment by mina.wor...@gmail.com on 25 May 2012 at 6:00

GoogleCodeExporter commented 9 years ago

Original comment by mina.wor...@gmail.com on 25 May 2012 at 6:02

GoogleCodeExporter commented 9 years ago 
sorry i verified and unverified then reverified your code because i was opening 
a wrong version
but now everything is ok

Original comment by mina.wor...@gmail.com on 25 May 2012 at 6:10

GoogleCodeExporter commented 9 years ago 
it wasn't working well after the second review cycle but  it's now working so 
I'll verify

Original comment by jailan.s...@gmail.com on 25 May 2012 at 7:39