Open GoogleCodeExporter opened 9 years ago
This issue was updated by revision r1233.
Done with the Task
Original comment by mina.wor...@gmail.com
on 13 May 2012 at 10:22
Why is still new?
Original comment by guc@sakr.me
on 13 May 2012 at 10:29
Original comment by mina.wor...@gmail.com
on 13 May 2012 at 10:33
Where is the UML, test, and documentation for this story?
Original comment by guc@sakr.me
on 13 May 2012 at 4:36
is the side issues need to have these proprieties ?
because this issue was created by christine she needs from me as a owner to add
in logs model this method.
Original comment by mina.wor...@gmail.com
on 13 May 2012 at 7:20
or we just remove these tags?
Original comment by mina.wor...@gmail.com
on 13 May 2012 at 8:30
If the method is there, it does need Documentation, a UML, and preferably a
Test to ensure your work is working. ;)
Original comment by guc@sakr.me
on 13 May 2012 at 8:33
no problem i will do them
Original comment by mina.wor...@gmail.com
on 13 May 2012 at 8:36
This issue was updated by revision r1459.
updating log.rb model
Original comment by mina.wor...@gmail.com
on 15 May 2012 at 7:07
This issue was updated by revision r1602.
updating log.rb model
Original comment by mina.wor...@gmail.com
on 17 May 2012 at 12:43
Log#self.get_All_Logs !! this doesn't follow ALL the conventions :D
Log#self.get_log_for_user is not indented properly (def and end are not on the
same column)
Original comment by yahiaelg...@gmail.com
on 19 May 2012 at 7:44
@ yahia this is sprint one msh hal3ab fiha
Original comment by mina.wor...@gmail.com
on 23 May 2012 at 9:27
This issue was updated by revision r2181.
Fixing some of the reviewers comments
Original comment by mina.wor...@gmail.com
on 23 May 2012 at 9:28
This issue was updated by revision r2182.
Update UML for getting the logs of certain user
Original comment by mina.wor...@gmail.com
on 23 May 2012 at 9:33
This issue was updated by revision r2196.
Added Test
Original comment by mina.wor...@gmail.com
on 23 May 2012 at 10:57
I verified the code, but it's not perfect. Maybe I am too picky as I am using
sublime (which displays the columns) and you use textmate. But, you shouldn't
make the " if condition " statement deeper than the rest of the code, the
if/else/end should be on the same column. The code executed should be on one
tab deeper.
Original comment by yahiaelg...@gmail.com
on 23 May 2012 at 1:29
Original comment by jailan.s...@gmail.com
on 25 May 2012 at 7:42
Original issue reported on code.google.com by
christin...@gmail.com
on 13 May 2012 at 10:07