just3obad / smartsoft-12

Automatically exported from code.google.com/p/smartsoft-12
0 stars 0 forks source link

User #147

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
User Model:
(Boolean) flag_story(story)
(List<story>)get_feed(String)
thumb_story(story,action)
(List<story>)get_interest_stories(Interest)
(<List<story>)get_unblocked_stories(List<stories>)

Original issue reported on code.google.com by kemoo...@gmail.com on 23 May 2012 at 9:40

GoogleCodeExporter commented 9 years ago
I suggest that some of these methods can be moved to the story model instead, 
The user model is too big already can you please re-check on that and let me 
know so that I'd add it accordingly.
Keep in mind that we want to minimize the methods in the user model as much as 
possible.

Original comment by elmen...@gmail.com on 23 May 2012 at 11:55

GoogleCodeExporter commented 9 years ago
I'm ccing you to get a notification!

Original comment by elmen...@gmail.com on 23 May 2012 at 11:56

GoogleCodeExporter commented 9 years ago
all these methods uses self<user> and is related to the user so it have be done 
here.

Original comment by kemoo...@gmail.com on 23 May 2012 at 1:15

GoogleCodeExporter commented 9 years ago
you can change the design like for example for flag story.
you can place it in the story model and pass a user parameter to it.

like:

story.flag(user)

As I said, we need to minimize the user class as much as possible.

Original comment by elmen...@gmail.com on 23 May 2012 at 1:16

GoogleCodeExporter commented 9 years ago
Kareem, please let me know what you reached because I need to update the class 
Diagram and remove redundancies ASAP!

Original comment by elmen...@gmail.com on 23 May 2012 at 2:36

GoogleCodeExporter commented 9 years ago
@Menisy .. make it as it is .. and i think its more logically right to do it 
like i am doing it.. and also there is no much time to do that

Original comment by kemoo...@gmail.com on 23 May 2012 at 2:54

GoogleCodeExporter commented 9 years ago
Ok, I won't add the first three as they are inferred from the relationships 
with the stories table, and I won't add get_interest_stories in the user model 
since it does not make sense to include it there.

Original comment by elmen...@gmail.com on 23 May 2012 at 5:38

GoogleCodeExporter commented 9 years ago

Original comment by elmen...@gmail.com on 23 May 2012 at 5:51