User

[GoogleCodeExporter]

Today I added these methods:

string block_interest_from_toggle1(interest)
string unblock_interest1(story)
string unblock_interest_from_toggle1(interest)
string unblock_story1(story)
array_story get_blocked_stories
string unblock_friends_feed1(friend)

I found in the class diagram you attached in the mail that my stories that i 
told you to add before have boolean return types although they should be string 
(This was in the document you shared for the return types). These methods are:

block_interest1, block_story1 and block_friends_feed1.

I have some methods that are in the controller not in model..do you need these?
in any case they are:
friends_feed (it renders a view with name friend_feed)
manage_blocked_stories (it renders a view with the same name)
manage_blocked_friends (it renders a view with the same name)
unblock_story_from_undo(story_id) and redirects to main feed.

Original issue reported on code.google.com by rana.hel...@gmail.com on 23 May 2012 at 4:53

[GoogleCodeExporter]

I don't need the controller. About the return types, I found that boolean is 
more descriptive. I also renamed your methods in the last version that I'm 
working on right now and removed the number 1 in their end since it does not go 
with the naming conventions. If you insist that I state the return types as 
strings and not boolean please let me know.

Original comment by elmen...@gmail.com on 23 May 2012 at 5:35

• Changed state: InProgress

[GoogleCodeExporter]

they should be String not boolean since I return a message  not true/false
and about the 1 do I need to edit my code so that remove the 1 or could I
leave it because this way I will have to rename and change all methods that
call them in the controller?!

please menisy discard the 2 methods named block_interest_from_toggle and
unblock_interest_from_toggle...and change the inputs of these 2 methods:
block_interest(interest) and unblock_interest(interest)

sorry for the changes but these things were something between me and omar
and he requested from me to change them now.

Original comment by rana.hel...@gmail.com on 23 May 2012 at 5:44

[GoogleCodeExporter]

It's ok, I removed block interest because it can be inferred from the 
relationships so there is no need for the change. About changing your method 
names, I believe it's better if you do it so that you don't lose any marks for 
not following the naming conventions.

Original comment by elmen...@gmail.com on 23 May 2012 at 5:58

• Changed state: Done