Closed GoogleCodeExporter closed 9 years ago
I don't need the controller. About the return types, I found that boolean is
more descriptive. I also renamed your methods in the last version that I'm
working on right now and removed the number 1 in their end since it does not go
with the naming conventions. If you insist that I state the return types as
strings and not boolean please let me know.
Original comment by elmen...@gmail.com
on 23 May 2012 at 5:35
they should be String not boolean since I return a message not true/false
and about the 1 do I need to edit my code so that remove the 1 or could I
leave it because this way I will have to rename and change all methods that
call them in the controller?!
please menisy discard the 2 methods named block_interest_from_toggle and
unblock_interest_from_toggle...and change the inputs of these 2 methods:
block_interest(interest) and unblock_interest(interest)
sorry for the changes but these things were something between me and omar
and he requested from me to change them now.
Original comment by rana.hel...@gmail.com
on 23 May 2012 at 5:44
It's ok, I removed block interest because it can be inferred from the
relationships so there is no need for the change. About changing your method
names, I believe it's better if you do it so that you don't lose any marks for
not following the naming conventions.
Original comment by elmen...@gmail.com
on 23 May 2012 at 5:58
Original issue reported on code.google.com by
rana.hel...@gmail.com
on 23 May 2012 at 4:53