search

just3obad / smartsoft-12

Automatically exported from code.google.com/p/smartsoft-12
0 stars 0 forks source link

3.9 As an admin , I could edit (rename) the interest in the system. #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Success scenarios:

Whenever the admin wants to edit/rename a certain interest he will have to  go 
to the interest's main page and there he will find the textfields to fill the 
image / name & description of this interests.. just filling those and clicking 
on the button update will save the cahnges and they will appear normally 
modified  .

Failure scenarios:
If the admin enters any invalid info in the fields a flash error message appear 
informing him of that 

Notes :

Points = 5
Priority = Medium

Original issue reported on code.google.com by jailan.s...@gmail.com on 9 May 2012 at 9:00

GoogleCodeExporter commented 9 years ago

Original comment by jailan.s...@gmail.com on 12 May 2012 at 1:15

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1181.

Adding Fixtures

Original comment by jailan.s...@gmail.com on 13 May 2012 at 4:39

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1182.

Adding Tests

Original comment by jailan.s...@gmail.com on 13 May 2012 at 4:57

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1214.

Adding model method Update

Original comment by jailan.s...@gmail.com on 13 May 2012 at 9:18

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1215.

Adding view part

Original comment by jailan.s...@gmail.com on 13 May 2012 at 9:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1220.

Modifying tests

Original comment by jailan.s...@gmail.com on 13 May 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1222.

Solving mY mistake after removing ( issue's 102 & 104) 
they are now back again

Original comment by jailan.s...@gmail.com on 13 May 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1276.

Documentation

Original comment by jailan.s...@gmail.com on 13 May 2012 at 6:14

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1441.

adding the story uml

Original comment by jailan.s...@gmail.com on 15 May 2012 at 5:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1559.

adding view statistocs Button

Original comment by jailan.s...@gmail.com on 16 May 2012 at 6:37

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1603.

styling

Original comment by jailan.s...@gmail.com on 17 May 2012 at 6:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1604.

Handling a case while testing

Original comment by jailan.s...@gmail.com on 17 May 2012 at 6:37

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1622.

Handling flash problems

Original comment by jailan.s...@gmail.com on 17 May 2012 at 11:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1623.

unit tests all passed

Original comment by jailan.s...@gmail.com on 17 May 2012 at 11:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1624.

functional tests all passed

Original comment by jailan.s...@gmail.com on 17 May 2012 at 11:30

GoogleCodeExporter commented 9 years ago 
Scenario-Reopened

1) The flash message resulting from an invalid input should be more 
descriptive, especially in the cases of (name field empty) and (incompatible 
file type for image) 

2) I tried to change the interest's image using gif,jpeg, png but it didn't 
work I get the invalid input flash

Original comment by kerolos.bebawy on 18 May 2012 at 3:24

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1702.

More descriptive flash error messages

Original comment by jailan.s...@gmail.com on 18 May 2012 at 9:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1719.

Image back again to its normal place

Original comment by jailan.s...@gmail.com on 18 May 2012 at 12:59

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1722.

adding log files

Original comment by jailan.s...@gmail.com on 18 May 2012 at 1:10

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by mouaz.alabsawi@gmail.com on 19 May 2012 at 1:11

GoogleCodeExporter commented 9 years ago 
Documentation should be in the format:
= begin
Method description
Parameters (inputs, outputs)
Author: jailan
= end
In addition to simple in line documentation to inside the methods

Original comment by bassemaw...@gmail.com on 19 May 2012 at 1:49

GoogleCodeExporter commented 9 years ago

Original comment by jailan.s...@gmail.com on 19 May 2012 at 10:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1866.

Modifying documentation according to the form

Original comment by jailan.s...@gmail.com on 19 May 2012 at 10:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1867.

Modifying documentation according to the form

Original comment by jailan.s...@gmail.com on 19 May 2012 at 10:40

GoogleCodeExporter commented 9 years ago 
The indentation is really bad in the (Interest Controller,Interest Model,and 
Interest View )please recheck them again 

and Some times you dont need to use the self.method
because this = to static method in java
the other type without self = instance method in java
work like this : @interest.is_deleted
instead of Interest.is_deleted(params[:id])
please try to this.

in the view please fix this : width="320" style="height:320px"

Add Push notification in your controller

this review is on all your stories i will copy paste it all over.

Original comment by mina.wor...@gmail.com on 20 May 2012 at 12:25

GoogleCodeExporter commented 9 years ago 
1- You should return a message when the test fails in the assert method (this 
applies to all your tests).
2- You should test for the save changes button.

Original comment by gosgosakila on 20 May 2012 at 1:18

GoogleCodeExporter commented 9 years ago 
Remove GREEN from all your tests also. No convention was set for that.

Original comment by gosgosakila on 20 May 2012 at 1:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1899.

Indentation

Original comment by jailan.s...@gmail.com on 20 May 2012 at 8:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1900.

Indentation

Original comment by jailan.s...@gmail.com on 20 May 2012 at 8:55

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1901.

Indentation

Original comment by jailan.s...@gmail.com on 20 May 2012 at 8:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1904.

added Flash Tests (Green) , added messages

Original comment by jailan.s...@gmail.com on 20 May 2012 at 9:08

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1905.

added Flash Tests (Green) , added messages

Original comment by jailan.s...@gmail.com on 20 May 2012 at 9:08

GoogleCodeExporter commented 9 years ago 
@Tests
-Save changes button is already checked in the "update" div Test .
- Green is removed
-added the Messages when fails .
-added the Flash Messages

@Implementation
-added push Notification
-Modified Indentation (revisions 1899 , 1900 & 1901 )

Original comment by jailan.s...@gmail.com on 20 May 2012 at 9:09

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1910.

solving method names in tests

Original comment by jailan.s...@gmail.com on 20 May 2012 at 9:24

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1951.

Green Tests after adding  admin session

Original comment by jailan.s...@gmail.com on 20 May 2012 at 12:14

GoogleCodeExporter commented 9 years ago 
Nice Work...as you added tests for add_interest which is from sprint 1.

Original comment by gosgosakila on 20 May 2012 at 12:48

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2106.

Handling a case , and updating the Flash messages text

Original comment by jailan.s...@gmail.com on 22 May 2012 at 5:00

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2107.

Styling

Original comment by jailan.s...@gmail.com on 22 May 2012 at 5:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2108.

changing the flash message test text after updating them in controller

Original comment by jailan.s...@gmail.com on 22 May 2012 at 5:02

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2300.

switching to use the new flash message type

Original comment by jailan.s...@gmail.com on 23 May 2012 at 6:04

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2301.

switching to use the new flash message type

Original comment by jailan.s...@gmail.com on 23 May 2012 at 6:05

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2303.

changing the flash messages to match the new ones

Original comment by jailan.s...@gmail.com on 23 May 2012 at 6:05

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2306.

styling the pop-up window when creating a new Interest

Original comment by jailan.s...@gmail.com on 23 May 2012 at 6:07

GoogleCodeExporter commented 9 years ago

Original comment by bassemaw...@gmail.com on 23 May 2012 at 6:33

GoogleCodeExporter commented 9 years ago

Original comment by mina.wor...@gmail.com on 23 May 2012 at 6:35

GoogleCodeExporter commented 9 years ago

Original comment by gosgosakila on 23 May 2012 at 7:05

GoogleCodeExporter commented 9 years ago 
Verified but add undo if possible

Original comment by kerolos.bebawy on 23 May 2012 at 7:48

GoogleCodeExporter commented 9 years ago

Original comment by yahiaelg...@gmail.com on 23 May 2012 at 11:10