search

just3obad / smartsoft-12

Automatically exported from code.google.com/p/smartsoft-12
0 stars 0 forks source link

1.10: As a registered user, I should be able to block feeds of certain interests. #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Success scenarios:
Under each story in the read more page, there are 2 buttons one to block this 
story and one to block all stories belonging to this interest. After the user 
chooses, a message appears that it was blocked and the story or all stories 
will be removed. The user is redirected to the main feed.

Failure scenarios:

If the story is not available anymore or removed, a pop up window will appear 
saying that the story was removed.

Original issue reported on code.google.com by rana.hel...@gmail.com on 10 May 2012 at 1:25

GoogleCodeExporter commented 9 years ago

Original comment by rana.hel...@gmail.com on 12 May 2012 at 1:46

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1132.

adding unit tests for model

Original comment by rana.hel...@gmail.com on 12 May 2012 at 10:49

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1134.

adding integration tests to test view

Original comment by rana.hel...@gmail.com on 12 May 2012 at 10:59

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1136.

add integration tests to test routes

Original comment by rana.hel...@gmail.com on 12 May 2012 at 11:02

GoogleCodeExporter commented 9 years ago 
Update Issue 92
Labels: Test-Ready

Original comment by rana.hel...@gmail.com on 12 May 2012 at 11:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1250.

Adding routes to my methods

Original comment by rana.hel...@gmail.com on 13 May 2012 at 4:06

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1255.

adding methods to controller and removing my old methods

Original comment by rana.hel...@gmail.com on 13 May 2012 at 4:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1256.

adding methods to model

Original comment by rana.hel...@gmail.com on 13 May 2012 at 4:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1258.

small change in test to create user correctly, tests passed, removed red word

Original comment by rana.hel...@gmail.com on 13 May 2012 at 4:48

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1264.

routing tests pass, removed red word

Original comment by rana.hel...@gmail.com on 13 May 2012 at 5:14

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1369.

removing commented line (not needed)

Original comment by rana.hel...@gmail.com on 14 May 2012 at 10:07

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1388.

Adding UML

Original comment by rana.hel...@gmail.com on 14 May 2012 at 11:06

GoogleCodeExporter commented 9 years ago

Original comment by christin...@gmail.com on 14 May 2012 at 11:18

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1472.

correcting very silly mistake in method block interest

Original comment by rana.hel...@gmail.com on 15 May 2012 at 7:53

GoogleCodeExporter commented 9 years ago 
Update Issue 92
Labels: Test-Ready Code-Ready UML-Ready Doc-Ready Scenario-Ready

Original comment by rana.hel...@gmail.com on 15 May 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1513.

all tests pass, remove red keyword

Original comment by rana.hel...@gmail.com on 15 May 2012 at 10:08

GoogleCodeExporter commented 9 years ago 
-he user<<actor>> should have a actor shape (check 1.2.png or 1.5.png to get 
what i mean. i did them on www.cacoo.com if you want to use it )

Original comment by omar.sae...@gmail.com on 16 May 2012 at 6:41

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1643.

updating message inserted in log file

Original comment by rana.hel...@gmail.com on 17 May 2012 at 5:27

GoogleCodeExporter commented 9 years ago 
The success and failure scenario of this story will be updated to accommodate 
for the newly added feature unblock a story

Success scenarios:
Under each story in the read more page, there are 2 buttons one to block this 
story and one to block all stories belonging to this interest. After the user 
chooses, a message appears that it was blocked and the story or all stories 
will be removed. The user is redirected to the main feed. 
From the settings page, the user can click on button manage blocked stories 
which redirects the user to the list of his blocked stories. Then, he can 
choose to unblock one and a message appears it was successful and he is 
redirected to the main feed.

Failure scenarios:

If the story is not available anymore or removed, a pop up window will appear 
saying that the story was removed. If the user has no blocked stories,a message 
notifies him that there are no blocked stories.

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1785.

Adding method for unblock feature in controller

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:13

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1786.

adding method to unblock story in model

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:17

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1787.

adding routes for unblock feature

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1792.

adding view to see blocked stories list (unblock feature)

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1795.

adding functional tests for unblock story feature

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1796.

adding tests for unblock story feature

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1797.

adding unit tests for unblock story feature

Original comment by rana.hel...@gmail.com on 18 May 2012 at 7:38

GoogleCodeExporter commented 9 years ago

Original comment by kelbhaey on 19 May 2012 at 3:00

GoogleCodeExporter commented 9 years ago 
After talking to SAKR we reached these guidelines to make a proper 
documentation.

First of all we will stick to that format of documentation for the whole 
company.

=begin
Description:
Input:   
Output:
Author:
=end

#Plus an inline documentation before each step u do inside that  method

#for Views Please Document the Important parts  of code  & give an overview 
about what this View does Exactly.

#For extra Help : Refer to my Actions in User Model. [after i commit for sure]

Original comment by kemoo...@gmail.com on 19 May 2012 at 3:47

GoogleCodeExporter commented 9 years ago 
see r1256

Original comment by christin...@gmail.com on 19 May 2012 at 7:45

GoogleCodeExporter commented 9 years ago 
Also see r1786

Original comment by christin...@gmail.com on 19 May 2012 at 7:53

GoogleCodeExporter commented 9 years ago 
see    r1792

Original comment by christin...@gmail.com on 19 May 2012 at 7:56

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
My numbers mean the following :

1) Check that it compiles.

2)Check that it complies with the naming convention

3) Check that each assert has a description (message)

and there's a note section.

Functional/users_controller_test.rb

test_get_block_story:
1) T
2) test_should_redirect_on_block_story
3) message : redirects on successful story block

test_get_block_interest:
1) T
2) test_should_redirect_on_block_interest
3) message : redirects on successful interest block

test_get_manage_blocked_stories_list:
1) T
2) test_should_get_manage_blocked_stories_list
3) assert messages

test_get_unblock_story:
1) T
2) test_should_redirect_on_unblock_story
3) assert message

Integration/user_test.rb

routes : I tried them all, they all work, please rename them to : 
test_should_get......

Integration/story_test.rb

test_form_for_button_block_interest_in_read_more_RED:
1) F
2) test_should_view_block_interest_button_in_read_more
3) assert messages
Notes :  replace the placeholder read_more_path(this_story) with the 
stories#get route

test_form_for_button_block_story_in_read_more_RED:
1) F
2) test_should_view_block_story_button_in_read_more
3) assert messages
Notes :  replace the placeholder read_more_path(this_story) with the 
stories#get route

Unit/user_test.rb

test_user_wants_to_block_interest:
1) T
2) test_interest_should_be_blocked
3) assert messages

test_user_wants_to_block_story:
1) T
2) test_user_should_be_blocked
3) assert messages

test_user_wants_to_unblock_story:
1) T
2) test_should_unblock_story
3) assert messages

test_user_wants_to_get_blocked_stories_list:
1) T
2) test_should_return_blocked_stories_list
3) assert messages

Please note that this is the defensive part of your review (meaning that this 
is the stuff that you've written) I've yet to check if there is need for an 
offensive test review in your code.

Original comment by mina.ade...@gmail.com on 20 May 2012 at 1:38

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1896.

adding correct format of documentation, fixed indentation

Original comment by rana.hel...@gmail.com on 20 May 2012 at 8:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1897.

adding correct format of documentation, fixed indentation

Original comment by rana.hel...@gmail.com on 20 May 2012 at 8:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1898.

fixed indentation, added documentation in the view

Original comment by rana.hel...@gmail.com on 20 May 2012 at 8:37

GoogleCodeExporter commented 9 years ago

Original comment by rana.hel...@gmail.com on 20 May 2012 at 8:39

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1902.

fixing a typo

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:06

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1903.

fixing relations to block_interest and block_story

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:07

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1994.

adding new umls to accomodate new features

Original comment by rana.hel...@gmail.com on 20 May 2012 at 5:28

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1997.

deleting old UML

Original comment by rana.hel...@gmail.com on 20 May 2012 at 5:35

GoogleCodeExporter commented 9 years ago 
@omar : i did not redo it on cacoo since it will be tough to do them on a new 
tool unless it is necessary and the whole company will do that. In the lecture, 
it is done the way top coder does it, so why change it?

Original comment by rana.hel...@gmail.com on 20 May 2012 at 5:44

GoogleCodeExporter commented 9 years ago

Original comment by christin...@gmail.com on 20 May 2012 at 8:32

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2051.

fixing functional tests

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2054.

fixed integration tests

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2055.

fixed unit tests in user_test

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:34

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2056.

remove unnecessary tests

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:46

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2057.

adding assert messages to tests

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:50

GoogleCodeExporter commented 9 years ago 
@mina: done with all your comments but note that I removed the two tests in the 
story controller since I was going to remove them anyway, I did not do the view 
for the button so I can not test them. omar should test these two buttons in 
testing his views

Original comment by rana.hel...@gmail.com on 20 May 2012 at 9:53

GoogleCodeExporter commented 9 years ago 
just one change
please remove the wish to block interest/story since you added under it "click 
on block"

Original comment by omar.sae...@gmail.com on 22 May 2012 at 3:54