search

just3obad / smartsoft-12

Automatically exported from code.google.com/p/smartsoft-12
0 stars 0 forks source link

1.6 As a registered user, I should be able to thumb up or down, flag a story as inappropriate. #99

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Success scenarios:
There are three buttons under each story;one for thumb up,one for thumb down, 
and one for flag. When a user clicks on one of these buttons, the number of 
thumbs/flags increase by 1 and it is disabled since he could thumb or flag 
once. If a user thumps up then down, both thumbs cancel each other. The user is 
not able to see the rate of flags of a story.
Failure scenarios:
If the story was removed, a pop up window will appear to the user saying that 
the story was removed. If the internet connection was lost, a message will be 
displayed saying that the connection was lost please try again later.

Original issue reported on code.google.com by kemoo...@gmail.com on 10 May 2012 at 5:47

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 11 May 2012 at 2:42

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 12 May 2012 at 7:16

GoogleCodeExporter commented 9 years ago 
A kind reminder that our deadline is in less than 2 hours.

Original comment by guc@sakr.me on 13 May 2012 at 8:19

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 13 May 2012 at 8:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1328.

Added current_user attribute

Original comment by kemoo...@gmail.com on 14 May 2012 at 5:28

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1334.

Added a parameter to a method

Original comment by kemoo...@gmail.com on 14 May 2012 at 5:52

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1488.

Added Documentation to actions

Original comment by kemoo...@gmail.com on 15 May 2012 at 8:53

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1493.

Documentation added

Original comment by kemoo...@gmail.com on 15 May 2012 at 9:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1548.

Added Flash option and redirect

Original comment by kemoo...@gmail.com on 16 May 2012 at 3:31

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 16 May 2012 at 9:06

GoogleCodeExporter commented 9 years ago 
karim can a user unlike a story after liking it ?? same with dislike 
ya3ni if you tried with menisy's comments you can like and if press again on he 
like button the number of likes decrease which i assume mean you removed your 
like.
same with dislike akeed

Original comment by omar.sae...@gmail.com on 18 May 2012 at 2:08

GoogleCodeExporter commented 9 years ago 
@Omar ,  Yes

Original comment by kemoo...@gmail.com on 18 May 2012 at 11:13

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1825.

Added Uml's

Original comment by kemoo...@gmail.com on 18 May 2012 at 9:28

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 18 May 2012 at 9:46

GoogleCodeExporter commented 9 years ago 
Documentation should be in the format:
= begin
Method description
Parameters (inputs, outputs)
Author: Karim
= end
In addition to simple in line documentation to inside the methods if possible

Original comment by mohamed....@gmail.com on 19 May 2012 at 2:41

GoogleCodeExporter commented 9 years ago

Original comment by kelbhaey on 19 May 2012 at 2:45

GoogleCodeExporter commented 9 years ago 
My numbers mean the following :

1) Check that it compiles.

2)Check that it complies with the naming convention

3) Check that each assert has a description (message)

and there's a note section.

test_create_new_flag :
1) T
2) should_create_new_flag
3) message : number of flags should increase by one
Notes : either create a user that contains a :password and 
:password_confirmation, or user users(:ben) for example, because your test now 
is passing when it shouldn't be.

test_try_flagged_user :
1) T
2) should_not_flag_if_user_flagged_story
3) message : number of flags shouldn't increase
Notes : either create a user that contains a :password and 
:password_confirmation, or user users(:ben) for example, because your test now 
is passing when it shouldn't be, also use proper associations

test_new_thumb_story
1) F
2) should_thumb_story
3) message : thumb count should increase
Notes : either create a user that contains a :password and 
:password_confirmation, or user users(:ben) for example.

test_thumb_story_again
1) F
2) should_not_thumb_story_if_already_thumbed
3) message : thumb count should not increase
Notes : either create a user that contains a :password and 
:password_confirmation, or user users(:ben) for example.

Please note that this is the defensive part of your review (meaning that this 
is the stuff that you've written) I've yet to check if there is need for an 
offensive test review in your code.

Original comment by mina.ade...@gmail.com on 19 May 2012 at 7:29

GoogleCodeExporter commented 9 years ago 
thumb_story():
DO NOT USE WHERE
thumped spelling mistake 
use elsif instead of else 
                        if
indentation

flag_story(story) :
NO USE OF WHERE
spelling mistake thumped
remove commented line
indentation

LOG FILES extreme importance check the wiki made by christine!!!

general note:
Note that: all lines should be less than 100 characters...no more and if a line 
is longer inline it like that:
def example_story()
  Story.create(:id => 1, :title =>
  "jajajaja"...)
end 
 note that the next line is inline with the first or after it NOT before it with the def!!!

Original comment by rana.hel...@gmail.com on 19 May 2012 at 8:12

GoogleCodeExporter commented 9 years ago 
flag_story

use associations do not create in table itself directly

Original comment by rana.hel...@gmail.com on 19 May 2012 at 8:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1909.

Modified tests

Original comment by kemoo...@gmail.com on 20 May 2012 at 9:23

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 20 May 2012 at 9:28

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1931.

Added Log file

Original comment by kemoo...@gmail.com on 20 May 2012 at 10:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1941.

indentation

Original comment by kemoo...@gmail.com on 20 May 2012 at 11:41

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 20 May 2012 at 1:31

GoogleCodeExporter commented 9 years ago

Original comment by mohamed....@gmail.com on 20 May 2012 at 3:58

GoogleCodeExporter commented 9 years ago 
there is  1.6 (1)  , 1.6 (2) , 1.6 (method 1) , 1.6 (method)
please check and delete the extra ones

Original comment by omar.sae...@gmail.com on 22 May 2012 at 4:00

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2138.

Added unlike option [OMAR]

Original comment by kemoo...@gmail.com on 22 May 2012 at 9:39

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2139.

Added new Flash option

Original comment by kemoo...@gmail.com on 22 May 2012 at 9:46

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2160.

Added filter with not added interest

Original comment by kemoo...@gmail.com on 23 May 2012 at 12:06

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2161.

Fixed a test

Original comment by kemoo...@gmail.com on 23 May 2012 at 12:33

GoogleCodeExporter commented 9 years ago 
-the un-like and the un-dislike is not working at all
(when i click the thump up again no thing change, same with thump down)
-when the user flag the story in the message remove the word successfully

and i just updated of course

Original comment by kelbhaey on 23 May 2012 at 12:51

GoogleCodeExporter commented 9 years ago 
when the user flag the story in the message there should be an undo button that 
will redirect him to read more and the flag is removed with anothor flash 
message telling him that he removed the flag

Original comment by kelbhaey on 23 May 2012 at 3:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2289.

Added fix for Unthumb option

Original comment by kemoo...@gmail.com on 23 May 2012 at 5:29

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 23 May 2012 at 6:59

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 23 May 2012 at 7:03

GoogleCodeExporter commented 9 years ago 
-when the user flag the story in the message remove the word successfully
-when the user flag the story in the message there should be an undo button 
that will redirect him to read more and the flag is removed with anothor flash 
message telling him that he removed the flag

Original comment by kelbhaey on 23 May 2012 at 8:24

GoogleCodeExporter commented 9 years ago 
No UNDO IS Requested in the backlog and sakr didn't mention any thing about it 
..  and there is no website in the world have undo flag option

Original comment by kemoo...@gmail.com on 23 May 2012 at 9:07

GoogleCodeExporter commented 9 years ago 
nothing is changed from what I told you.

Original comment by rana.hel...@gmail.com on 23 May 2012 at 9:26

GoogleCodeExporter commented 9 years ago 
-when the user flag the story in the message remove the word successfully(still 
there)
-when the user flag the story in the message there should be an undo button 
that will redirect him to read more and the flag is removed with anothor flash 
message telling him that he removed the flag(in case he mistakenly press the 
flag there should be a way to undo that and that what sakr said about 
mistakenly press something)

Original comment by kelbhaey on 23 May 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
No UNDO IS Requested in the backlog and sakr didn't mention any thing about it 
..  and there is no website in the world have undo flag option

Original comment by kemoo...@gmail.com on 23 May 2012 at 9:48

GoogleCodeExporter commented 9 years ago 
I WANT YOU TO TELL ME IF THE USER MISTAKENLY FLAG A STORY WHAT I SHOULD DO
AND 
REMOVE SUCCESSFULY

Original comment by kelbhaey on 23 May 2012 at 9:51

GoogleCodeExporter commented 9 years ago 
@rana
Already using elsif
#for WHERE i asked yahia and he tolled me it's ok
#identation done
#log file done
#no lines more than 100

Original comment by kemoo...@gmail.com on 23 May 2012 at 10:00

GoogleCodeExporter commented 9 years ago 
1.6(1)
- the get view should be written "stories/ get " not "story (get) "
-remove <action> 
- "if thumbed b4 and try new action" ?? try to be more descriptive and write 
proper english "b4" should be "before" and proper condition like  "if (... && 
...) then"
- arrow from likedislike <<controller>> to get << view >> remove view from 
arrow and 
write " render view "
 do same for 1.6(2)

Original comment by omar.sae...@gmail.com on 24 May 2012 at 5:37

GoogleCodeExporter commented 9 years ago 
No using where and select is UNACCEPTABLE as me and the other implementation 
reviewers including Yahia agreed upon.These should be changed. use find
commented line 456 remove it in users model
You are creating in flag and likedislike as though they are not relations!!
these should be done through the associations and this was said before more 
than once.

Original comment by rana.hel...@gmail.com on 24 May 2012 at 8:45

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 24 May 2012 at 9:47

GoogleCodeExporter commented 9 years ago 
for UML if(!flagged) -> create recored 
where is the case for if(flagged)

Original comment by omar.sae...@gmail.com on 24 May 2012 at 9:48

GoogleCodeExporter commented 9 years ago 
if not flagged it does nothing

Original comment by kemoo...@gmail.com on 24 May 2012 at 9:59

GoogleCodeExporter commented 9 years ago 
a flash that he already flagged this story

Original comment by omar.sae...@gmail.com on 24 May 2012 at 10:00

GoogleCodeExporter commented 9 years ago

Original comment by mina.ade...@gmail.com on 25 May 2012 at 7:27

GoogleCodeExporter commented 9 years ago

Original comment by kemoo...@gmail.com on 25 May 2012 at 8:52