Closed simesy closed 5 months ago
Feels to me that there are some missing instruction somewhere, with the changes in this PR, running a Functional test:
ddev phpunit core/modules/shortc
ut/tests/src/Functional/GenericTest.php
Clearing old webdriver sessions
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.6
Configuration: /var/www/html/core/phpunit.xml
Testing Drupal\Tests\shortcut\Functional\GenericTest
E 1 / 1 (100%)R
Time: 00:00.465, Memory: 4.00 MB
There was 1 error:
1) Drupal\Tests\shortcut\Functional\GenericTest::testModuleGenericIssues
Drupal\Core\Installer\Exception\InstallerException: Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/docs/installing-drupal">installation handbook</a>, or contact your hosting provider.<ul><li>Failed to connect to your database server. The server reports the following message: <em class="placeholder">SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo for db failed: Name or service not known [Tip: This message normally means that there is no MySQL server running on the system or that you are using an incorrect host name or port number when trying to connect to the server. You should also check that the TCP/IP port you are using has not been blocked by a firewall or port blocking service.] </em>.<ul><li>Is the database server running?</li><li>Does the database exist or does the database user have sufficient privileges to create the database?</li><li>Have you entered the correct database name?</li><li>Have you entered the correct username and password?</li><li>Have you entered the correct database hostname and port number?</li></ul></li></ul>
If I add - SIMPLETEST_DB=sqlite://localhost/sites/default/files/db.sqlite
to my env variables for the web container:
ddev phpunit core/modules/shortcut/tests/src/Functional/GenericTest.php
Clearing old webdriver sessions
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.6
Configuration: /var/www/html/core/phpunit.xml
Testing Drupal\Tests\shortcut\Functional\GenericTest
. 1 / 1 (100%)
Time: 00:03.586, Memory: 4.00 MB
OK (1 test, 9 assertions)
@simesy there are massive differences between this PR and the one you previously proposed (#23)
git diff simesy/main simesy/upstream
shows
By closing the other one, you invalidated all the reviews there. And then opening this one with major changes leaves us all confused.
Would you mind reopening the other one and closing this one? If you need help figuring out what was going wrong, I'm happy to help.
If you'd rather, I can open a replacement PR for #23 I guess and give you credit in the commit.
Per conversation with @simesy this can be closed in favor of
Updates the plugin for ddev 1.23.
The original issue was here, however the base branch changed so i need to create a new PR.
Test by cloning the forked repo and using slightly different commands.