search

justafish / ddev-drupal-core-dev

ddev addon for core development
Apache License 2.0
24 stars 10 forks source link

Depend on ddev/ddev-selenium-standalone-chrome instead of directly using seleniarm/standalone-chromium #32

Closed rfay closed 3 weeks ago

rfay commented 6 months ago

Currently this add-on uses seleniarm/standalone-chromium in its own docker-compose.core-dev-selenium.yaml

But the ddev/ddev-selenium-standalone-chrome is well-maintained and provides these facilities.

What about requiring that add-on as a dependency instead of requiring the docker-compose.core-dev-selenium.yaml here?

justafish commented 3 weeks ago

Thanks for the suggestion! I'd like to keep control over the image version being used though, and I do intend to complete the firefox support :smiley_cat: