search

justafish / ddev-drupal-core-dev

ddev addon for core development
Apache License 2.0
24 stars 10 forks source link

feat: Allow installing and testing with all database types, including MariaDB #34

Open rfay opened 5 months ago

rfay commented 5 months ago

(Draft: This has to be rebased after

This PR allows using any database type supported by DDEV, including MariaDB and MySQL. And of course it can still use sqlite.

It currently includes unmerged PRs because drush is required for it.

I guess it still needs tests, will wait until after rebase.

joachim-n commented 3 weeks ago

@rfay Could you rebase this against main please? There are a lot of conflicts and I don't know what I'm doing with the code involved.

rfay commented 3 weeks ago

I can rebase this and https://github.com/justafish/ddev-drupal-core-dev/pull/33, but it will still be dependent on https://github.com/justafish/ddev-drupal-core-dev/pull/33

joachim-n commented 3 weeks ago

Ah drat, I hadn't seen this depended on #33. Too many balls in the air, sorry!

joachim-n commented 3 weeks ago

I don't know if in my fork I want to support both styles of installation, or just using my Composer project template. I was initially thinking I'd support both, if it's not too much faff.

rfay commented 3 weeks ago

This is rebased against

But of course it still depends on #33.

rfay commented 3 weeks ago

I don't know if in my fork I want to support both styles of installation, or just using my Composer project template. I was initially thinking I'd support both, if it's not too much faff.

All I care about here is using a "normal" database type, and having drush available. I'm pretty sure your template is a fine way to do that, true?

joachim-n commented 3 weeks ago

Yup, but what I mean is if I drop support for running this directly in a Drupal core clone, then none of #33 is needed.

rfay commented 3 weeks ago

Again, any way you get drush works for me :)