search

justafish / ddev-drupal-core-dev

ddev addon for core development
Apache License 2.0
24 stars 10 forks source link

Changed to allow phpunit.xml file in project root. #37

Closed joachim-n closed 3 weeks ago

AKocherhin commented 2 months ago

Hi @joachim-n Might be better put "Allow phpunit.xml file in project root" into its own command And we can call i something like ddev phpunit_root

or use some another flag for example --root_conf What do you think?

joachim-n commented 2 months ago

I think it's better UX if it's automatic.

I don't think a separate command or a flag makes sense -- you either have it set up with phpunit.xml in the root, or you're using the one in core, and it's like that for your project all the time.

AKocherhin commented 2 months ago

ok. I agree. in this case, we need changes in documentations too. Could you please add?

justafish commented 3 weeks ago

Thanks for the PR @joachim-n - core/phpunit.xml is already used by this project and gitignored, so you're welcome to modify it for your own purposes or run ddev exec phpunit for your own custom flags.