Improve initial instructions to use current clone etc

justafish / ddev-drupal-core-dev

ddev addon for core development

Apache License 2.0

24 stars 10 forks source link

Improve initial instructions to use current clone etc #8

Closed rfay closed 7 months ago

rfay commented 8 months ago

We did a LONG support help in Drupal #ddev Slack with quite a number of stumbles on this.

Use current git clone technique (it may need --branch as well) (https://www.drupal.org/node/3060/git-instructions/11.x/nonmaintainer)
Use a directory name and project name that is more suited, like core-dev
Current stable DDEV does not detect drupal11 (which is HEAD) so ddev config --auto gets the php project type.
Don't use && for setup because people won't pay attention to failures.

Obviously the --project-type=drupal10 will want to be updated when DDEV has support for drupal11 later this year. It will probably be --project-type=drupal then.

rpkoller commented 7 months ago

one suggestion instead of ddev config --auto use ddev config --omit-containers=db, since the add-on is using sqlite and not any of the database containers ddev is providing. save a little bit of diskspace and makes it clear that another db than mysql, mariadb or postgres is used.

rfay commented 7 months ago

This PR already stops using --auto and instead gives specific project type. But I see no harm in --omit-containers=db.

Note that running db container doesn't use up any disk space, but does use some memory.

rpkoller commented 7 months ago

oh it was too late when i was reading the files changed section this morning. you are right. sorry. and about the db container. if i do a docker image ls there is one db container for the project that is using the ddev-drupal-core-dev addon:

ddev/ddev-dbserver-mariadb-10.4    20240213_mariadb_1011_default-drupalcore-built   d5622e591ce3   2 days ago     649MB

so some diskspace is used for that?

rfay commented 7 months ago

There has to be, but I think you'll find it's trivial.