Fixing errors - Githubissues

justagist / panda_robot

A ROS python interface for using the franka robot (requires franka_ros_interface). Simplified control and management API.

https://justagist.github.io/panda_robot

Apache License 2.0

85 stars 17 forks source link

Fixing errors #6

Closed MyGodItsFull0fStars closed 3 years ago

MyGodItsFull0fStars commented 3 years ago

Added requirements.txt file, added paranthesis to print statements in panda_kinematics.py file and changed double quotes to single quotes for string values.

MyGodItsFull0fStars commented 3 years ago

The naming of the branch was chosen because this project did initially not work properly on my machine. Some packages, which are mentioned in the commited requirements.txt file where needed (the first 3 lines are copy-pasted from the panda_simulation repository)

justagist commented 3 years ago

Thanks for the PR. These are my thoughts, let me know if you disagree.

Except for PyKDL, the other requirements should be added for the Franka ROS Interface repository (which is currently undergoing some work in improving the documentation). Also, not all of them are pip packages.
I don't see any reason for switching from double-quotes to single-quotes? Or for using parenthesis in print statements for Python2.

MyGodItsFull0fStars commented 3 years ago

Thank you for sharing your thoughts, seems that the PR is not really necessary, here my thoughts based on your bullet points:

Yes, that might be a better option.
The usage of single quotes is more of a coding guideline. Obviously consistency inside the project is key and preferable. I now read some more about the differences between the usage of the print statement with/without paranthesis, and the usage of paranthesis might result in unwanted behaviour, so please reject that change link.