justarandomgeek / factorio-simhelper

MIT License
0 stars 1 forks source link

Function Capture #1

Closed JanSharp closed 2 years ago

JanSharp commented 2 years ago

The feature is completely done and tested, there are just a few things I'd like feedback on before you merge it. 1) should the example in the modloader.md file also use the func capture helper (I think it should, but then it's not actually an example from nixie tubes, unless you update that mod just to use the func capture helper, or we just don't care that it's an exact example)? 2) should the docs be merged into one file?

Otherwise I've basically done things the way I wanted to, however that doesn't mean they have to stay that way. And note that I did change the info.json file. Imo the test scenario should not be part of the published mod. (I'm noting this explicity because I saw that in conman it was in the published mod, though I didn't double check if it would show up in game... but i don't know of any reason why it wouldn't)