justarandomgeek / vscode-factoriomod-debug

Factorio Mod Tool Kit
Other
97 stars 21 forks source link

Generated config not portable #84

Open Sharparam opened 1 year ago

Sharparam commented 1 year ago

When the VSCode extension sets up settings.json, the paths it inserts are hardcoded for the current user and machine, and will (most likely) not work on another user's setup (or another machine of the same user).

Is it possible to add an option to generate all the files inside the active workspace/repo? Instead of the user's home folder. (Kinda similar to how some Python projects put the virtual env inside a .venv folder inside the repo.)

justarandomgeek commented 1 year ago

I used to do it all in-workspace and got tons of complaints from users, resulting in the move to the workspaceStorage location! IIRC there was also some trouble with the LauLS interop with it all in-tree, but i've honestly forgotten exactly what that was.

I'm still holding out hope for a real inter-extension api for LuaLS so that these paths can be communicated without writing them to settings at all.

Sharparam commented 1 year ago

Or if VS Code had a way to use a variable to point to the workspace storage location. The settings.json is very lacking in that department (many variables that work elsewhere are not supported in it sadly).

justarandomgeek commented 1 year ago

Or if VS Code had a way to use a variable to point to the workspace storage location. The settings.json is very lacking in that department (many variables that work elsewhere are not supported in it sadly).

it's mostly up to the individual extensions to substitute those, so again it would be up to LuaLS to provide it! :(

When i finish the work that's currently breaking everything else though i'll have another look at what the options for dealing with this are and see if anything has improved since I last tried.