justarrived / just-match-frontend

[ABANDONED] Frontend for JustMatch API
https://antrop.invisionapp.com/share/FA62UU66R
MIT License
2 stars 9 forks source link

Page scrolling behind modal #664

Open pstenstrm opened 8 years ago

pstenstrm commented 8 years ago

Description

This is one problem but it causes two main issues. I'm adding both of them to the same issue as they share fix.

  1. When the user opens a modal they can scroll the hidden page behind it. This can be confusing when the user no longer recognises where they are, or know what they did to cause the change.
  2. In iOS. When a modal has "internal scroll", when all content don't fit on the screen, it can be hard to scroll down on touchscreens. If the modal is in top position and the user scrolls up, the scroll-event will move to the next scrollable element above. When the user then scrolls down without lifting the finger the same element will receive the scroll-event.

It is very common, depending on how the user "attacks" the screen, that they will accidentally scroll a few pixels up. This means that they will be unable to scroll down in modals. They will instead scroll the page behind it.

Severity:

URL: http://justarrived.dev-machine.com/#/

Role: Any

1. How to recreate it

  1. Goto http://justarrived.dev-machine.com/#/
  2. Click menu icon
  3. Scroll down
  4. Close menu

What happened The user returns to the page in a different position from where they left it.

Expected outcome The user should return to the page where they left it

2. How to recreate it

  1. Goto http://justarrived.dev-machine.com/#/
  2. Click language icon
  3. Scroll up
  4. Scroll down without changing grip

What happened The modal is not scrolling.

Expected outcome The modal should scroll down.

Browser (check what browser you're running at https://whatbrowser.org): iPhone 6 iOS 9 Safari (Can test in Xcode simulator, can not test in chrome emulator)