Closed pstenstrm closed 8 years ago
Could you perhaps provide a screenshot for comparison? :)
cc @camillaryd, what do you think about the new color code?
Wherever there used to be text on dark hot pink it is now cerice, one panel is berry.
Small details like the left border on chat entrances or active tab remains dark hot pink.
@pstenstrm awesome! Thanks for the screenshots!
@camillaryd what are your thoughts on the above ☝️? :)
I've changed the .pink
classname to .primary
. The $pink
variable remains dark hot pink while everywhere the class was used the color is now cerice. I didn't want to name the class .cerice
to avoid having to change it again if the color changes. But it's inconsistent with the .blue
and .dark
classnames that we still have.
:+1: for changing pink
=> primary
.
How do you think we should rename blue
and dark
? secondary
and... ¯(ツ)/¯
secondary
would be good instead of dark
. blue
is only used once, so there's really no red thread to follow, but it's also less of a problem.
Seems like @camillaryd 👍 this :) https://github.com/justarrived/just-match-frontend/issues/684#issuecomment-232157654
I'm also 👍 for merge :) @pstenstrm could you fix the merge conflict and then you can merge? You have commits rights now if I'm not mistaken 😄
🎉
There was a few additional places where dark hot pink was used as a background color for white text. I changed those places to cerice as well. Any dark hot pink details and texts remains dark hot pink.