justarrived / just-match-frontend

[ABANDONED] Frontend for JustMatch API
https://antrop.invisionapp.com/share/FA62UU66R
MIT License
2 stars 9 forks source link

Issue/684 #705

Closed pstenstrm closed 8 years ago

pstenstrm commented 8 years ago

There was a few additional places where dark hot pink was used as a background color for white text. I changed those places to cerice as well. Any dark hot pink details and texts remains dark hot pink.

buren commented 8 years ago

Could you perhaps provide a screenshot for comparison? :)

cc @camillaryd, what do you think about the new color code?

pstenstrm commented 8 years ago

Wherever there used to be text on dark hot pink it is now cerice, one panel is berry. justarrived684

Small details like the left border on chat entrances or active tab remains dark hot pink. justarrived-job684 justarrived-candidate684

buren commented 8 years ago

@pstenstrm awesome! Thanks for the screenshots!

@camillaryd what are your thoughts on the above ☝️? :)

pstenstrm commented 8 years ago

I've changed the .pink classname to .primary. The $pink variable remains dark hot pink while everywhere the class was used the color is now cerice. I didn't want to name the class .cerice to avoid having to change it again if the color changes. But it's inconsistent with the .blue and .dark classnames that we still have.

buren commented 8 years ago

:+1: for changing pink => primary.

How do you think we should rename blue and dark? secondary and... ¯(ツ)

pstenstrm commented 8 years ago

secondary would be good instead of dark. blue is only used once, so there's really no red thread to follow, but it's also less of a problem.

buren commented 8 years ago

Seems like @camillaryd 👍 this :) https://github.com/justarrived/just-match-frontend/issues/684#issuecomment-232157654

I'm also 👍 for merge :) @pstenstrm could you fix the merge conflict and then you can merge? You have commits rights now if I'm not mistaken 😄

buren commented 8 years ago

🎉