Unclear error message, the user can't see what it is that needs to be fixed in order to proceed

justarrived / just-match-web

JustMatch Web

https://app.justarrived.se

5 stars 1 forks source link

Unclear error message, the user can't see what it is that needs to be fixed in order to proceed #224

Closed tikkat closed 7 years ago

tikkat commented 7 years ago

bex1 commented 7 years ago

@tikkat What other input was provided?

tikkat commented 7 years ago

@bex1 it's probably the bank details that are the cause of the problem, it is when I have the wrong number of digits there that I get the error message. This one needs better copy :) Is it a catch-all scenario for submit? Maybe we need to add more specific error messages?

bex1 commented 7 years ago

Ah I see that only a clearing number of 4 digits and account number of 7 didigts are allowed now in the api. This has to be changed @buren

These formats has to be supported: Affärsbankernas standard: CCCC – XX XXX XX (4 + 7 = 11 siffror) Handelsbankens standard: CCCC – XXX XXX XXX (4 + 9 = 13 siffror) Sparbankernas (Swedbank) standard: CCCC-C XXX XXX XXXX (5 + 10 = 15 siffror)

Swedish accounts are what should be used right? @tikkat @buren

bex1 commented 7 years ago

@buren Also errors for fields account_number and account_clearing_number are not sent to the frontend on PATCH /api/v1/users/:id

buren commented 7 years ago

@bex1 will fix!