Working e2e and unit test env. e2e uses local selenium server. Need t…

justarrived / just-match-web

JustMatch Web

https://app.justarrived.se

5 stars 1 forks source link

Working e2e and unit test env. e2e uses local selenium server. Need t… #381

Closed bex1 closed 7 years ago

bex1 commented 7 years ago

…o be verified that --aot does not break.

Changes to tsconfig files are done according to angular cli seed.

New commands: yarn run e2e <--- runs e2e tests yarn run test <--- runs unit tests yarn run lint <--- lints ts files

@buren Before merge, can you verify that this PR does not break build with --aot. Have difficulties compiling on Windows.... Maybe I should get a MacBook once afterall :)

closes #309

burenbot commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/justarrived/just-match-web/pulls/381.

buren commented 7 years ago

Awesome @bex1 👍 Code looks good!