search

justarrived / just-match-web

JustMatch Web
https://app.justarrived.se
5 stars 1 forks source link

Update deps #413

Closed bex1 closed 7 years ago

bex1 commented 7 years ago

closes #407 closes #388

Upgraded to Angular 4 successfully.

Moved from ng2-translate to ngx-translate. (new package name)

Updated all deps to latest except tslint since codelyzer breaks on tslint above 4.X.X currently, will be fixed soon.

angular2-google-maps has incorrect peer deps for 2.x.x. But non breaking on 4.x.x. Just a npm publish is missing. See: https://github.com/SebastianM/angular2-google-maps/issues/968

Big headsup:

ng-semantic pulled into the app and successfully mimimized and integrated.

This will allow us to keep it up to date with angular 4 deps and easily extend and improve it since it is not really maintained anymore but by me. I believe we can do a better job than the original author anyways, its only 20-ish components/directives at approx 1000 LOC. Note JQuery is still only allowed throughout the semantic code-base.

burenbot commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/justarrived/just-match-web/pulls/413.

buren commented 7 years ago

Awesome! Absolutely awesome 😻

Also 👍 for pulling in Semantic... seems small enough to maintain ourselves, plus it will be a lot easier to change now, since we don't have to go through the hassle of updating another repo and then pulling that into this codebase.