search

justarrived / just-match-web

JustMatch Web
https://app.justarrived.se
5 stars 1 forks source link

Update the start page top-banner to look more like our website #487

Closed buren closed 7 years ago

buren commented 7 years ago

Update the start page top-banner to look more like our website and refactor welcome-header-component.

Before

screen shot 2017-05-26 at 13 46 29 screen shot 2017-05-26 at 13 46 23 screen shot 2017-05-26 at 13 46 11

After

screen shot 2017-05-26 at 13 45 53 screen shot 2017-05-26 at 13 45 36 screen shot 2017-05-26 at 13 49 55 screen shot 2017-05-26 at 13 49 43

bex1 commented 7 years ago

I also did this. Looks great 👍 Very similar but I think the buttons should be stacked as before and fluid so they are the same width. It does not look pixel perfect when they are diffing in size. Ill merge this branch into my home page redesign and update the buttons and we are good to deploy. @buren

bex1 commented 7 years ago

Just one tip: Avoid using *ngIf with method calls. The change detection is far more optimized for boolean expressions inlined in the html. Only use methodcalls on events like clicks etc.

buren commented 7 years ago

Awesome thanks for the review ☺️