justarrived / just-match-web

JustMatch Web
https://app.justarrived.se
5 stars 1 forks source link

On staging and production servers share the cookie between subdomains #543

Closed buren closed 6 years ago

buren commented 6 years ago

We want to detect whether the user is logged in on other subdomains than app.justarrived.se.

This PR updates the cookie storage code to share its cookie with subdomains of justarrived.se and justarrived.xyz


@bex1 will this cause any problems with server side rendering?

buren commented 6 years ago

The CI is failing because it installs yarn v1.1 which is incompatible with our version of node (v6.11). We should probably upgrade our node version its quite out of date.

We're not going to be able to deploy if heroku decides to use yarn v1.1..

bex1 commented 6 years ago

👍 Nice! LGTM