justarrived / just-match-web

JustMatch Web
https://app.justarrived.se
5 stars 1 forks source link

Angular v5 #555

Closed buren closed 6 years ago

buren commented 6 years ago

Tried to apply the below patch, but couldn't get it fully working. The problem is that require('../dist/server/main.bundle') can't be resolved.

Links


EDIT: Removed the inline diff.

buren commented 6 years ago

sweet that you got server rendering working @bex1 🎉

I found this, very, detailed blog post about angular 5 and transfer state. You need to scroll waay down to find the relevant parts for transfer state. https://medium.com/@evertonrobertoauler/angular-5-universal-with-transfer-state-using-angular-cli-19fe1e1d352c

(He also mentions the optimization flag --build-optimizer that we don't use.)

burenbot commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

But beware that this branch is 6 commits behind the justarrived:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/justarrived/just-match-web/pulls/555.