justas-d / mpd-rich-presence-discord

Broadcast your MPD state using discord rich presence!
MIT License
84 stars 17 forks source link

Added flag to only broadcast when playing #12

Closed taahamahdi closed 4 years ago

taahamahdi commented 4 years ago

I was planning to name the flag --no-pause to match --no-idle, but the -p substring of --no-pause was interfering with the port number flag. The new flag is --unpaused.

taahamahdi commented 4 years ago

Sorry for the wait! I've made the corrections you suggested

taahamahdi commented 4 years ago

Hey -- I was just thinking about how we decided to implement the change, and --dont-broadcast-the-paused-state won't actually work in this case either. Sorry about not realizing this earlier! I get a std::invalid_argument when passing --dont-broadcast-the-paused-state :[

The reason it won't work is because of the -p substring: won't this get mistaken for -p's port option too, just like when --no-pause didn't work?

Edit: typo

taahamahdi commented 4 years ago

Would --unpaused-broadcast-only work for you?

justas-d commented 4 years ago

ced628d3eaf3f18c5eff286b0955c605616348ee should fix it.