replaced top and bottom shadow by background shadow 9patch

justasm / DragLinearLayout

Android LinearLayout with drag and drop to reorder.

MIT License

453 stars 121 forks source link

Open meesec opened 8 years ago

meesec commented 8 years ago

suggested fix for recent discussion around drag shadow.

justasm commented 8 years ago

Nice! Thanks a lot, I like this solution. Would be interested to hear from @escobar5 if this solves #25.

Minor nitpicks:

The 9-patch shadow is a bit too dark imo, I think it may look nicer if the opacity was lower.
We should include a 9-patch for each of the common densities.

meesec commented 8 years ago

updated.

i checked on an ldpi emulator, seems to work fine with the xxhdpi 9patch.

set alpha to 75 on the shadow. feel free to pick a different alpha.

justasm commented 8 years ago

What did you use to generate the 9-patch?

meesec commented 8 years ago

A designer in my project build it a while ago. I assume sketch.

escobar5 commented 8 years ago

thanks, I will check it as soon as I can

daktarin commented 6 years ago

How can I remove shadow when moving?