search

justbetter / magento2-sentry

Magento 2 module to log to Sentry
MIT License
165 stars 70 forks source link

Make extension available for Adobe Commerce Cloud #121

Closed ArjenMiedema closed 11 months ago

ArjenMiedema commented 11 months ago

Summary

Adobe Commerce Cloud doesn't have the option to set data using the "Magento Deployment Configuration" strategy, making it impossible to setup Sentry for Adobe Commerce Cloud. With this update it's possible to set the configuration within the Magento admin, with a fallback to the original strategy.

See: https://github.com/justbetter/magento2-sentry/issues/80

Result

ArjenMiedema commented 11 months ago

@indykoning can you check if the changes I made are sufficient or if more changes are required/wanted? Would be awesome if we can merge this to the main branch with a new version.

JKingma commented 11 months ago

@indykoning are you able to review these changes? We also want to use this.

indykoning commented 11 months ago

Looks good and doesn't seem to be having any problems with an already set up installation 🚀 Would you be able to update the readme how to set sentry up on Commerce? 🙂

ArjenMiedema commented 11 months ago

@indykoning I updated the README. Please let me know if this is clear enough.

indykoning commented 11 months ago

Thank you 🚀 We have just released this in version 3.5.0!